Skip to content

Conversation

kpavlov
Copy link
Collaborator

@kpavlov kpavlov commented Oct 3, 2025

Add llmProvider method to LLM clients and extend MultiLLMPromptExecutor constructors

  • Implemented llmProvider method for all LLM client implementations for better provider identification.
  • Updated MultiLLMPromptExecutor to accept LLMClient instances directly, simplifying constructor usage.
  • Adjusted tests and documentation accordingly.
  • Register MultiLLMPromptExecutor as Spring bean

Motivation and Context

LLMClient is de-facto associated with LLMProvider as 1-to-1

Breaking Changes

No


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

@kpavlov kpavlov added enhancement New feature or request refactoring Code improvements that enhance structure, readability, and quality without changing functionality and removed enhancement New feature or request labels Oct 3, 2025
@kpavlov kpavlov marked this pull request as ready for review October 3, 2025 14:39
@kpavlov kpavlov requested a review from Ololoshechkin October 3, 2025 14:40
…cutor` constructors

- Implemented `llmProvider` method for all LLM client implementations for better provider identification.
- Updated `MultiLLMPromptExecutor` to accept `LLMClient` instances directly, simplifying constructor usage.
- Adjusted tests and documentation accordingly.

Add MultiLLM auto-configuration (Spring) and enhance bean registration tests

- Introduced `MultiLLMAutoConfiguration` to support `MultiLLMPromptExecutor` setup.
- Updated integration test to validate `MultiLLMPromptExecutor` bean registration.
- Refined test methods to better assert generic bean types.
@kpavlov kpavlov force-pushed the kpavlov/multiexecutor branch from af4e720 to b4ffe57 Compare October 3, 2025 14:55
…cutor` constructors

- Implemented `llmProvider` method for all LLM client implementations for better provider identification.
- Updated `MultiLLMPromptExecutor` to accept `LLMClient` instances directly, simplifying constructor usage.
- Adjusted tests and documentation accordingly.

Add MultiLLM auto-configuration (Spring) and enhance bean registration tests

- Introduced `MultiLLMAutoConfiguration` to support `MultiLLMPromptExecutor` setup.
- Updated integration test to validate `MultiLLMPromptExecutor` bean registration.
- Refined test methods to better assert generic bean types.
@kpavlov kpavlov changed the title Add llmProvider method to LLM clients and extend MultiLLMPromptExecutor constructors Add llmProvider method to LLM clients, extend MultiLLMPromptExecutor constructors, register Spring bean Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

Qodana for JVM

1009 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 962
Vulnerable imported dependency 🔶 Warning 30
Missing KDoc for public API declaration 🔶 Warning 11
Unused import directive 🔶 Warning 6
@@ Code coverage @@
+ 71% total lines covered
14244 lines analyzed, 10117 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvements that enhance structure, readability, and quality without changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant