Skip to content

Fix Path.of() InvalidPathException on Windows in MavenSystemIndicesMa… #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Path.of() InvalidPathException on Windows in MavenSystemIndicesMa… #3233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion plugins/maven/src/main/java/org/jetbrains/idea/maven/indices/MavenSystemIndicesManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import org.jetbrains.idea.maven.utils.MavenProgressIndicator
import org.jetbrains.idea.maven.utils.MavenUtil
import java.net.URI
import java.net.URISyntaxException
import java.nio.file.InvalidPathException
import java.nio.file.Path
import java.util.*
import java.util.concurrent.ConcurrentHashMap
Expand Down Expand Up @@ -184,7 +185,12 @@ class MavenSystemIndicesManager(val cs: CoroutineScope) : PersistentStateCompone


private fun getCanonicalUrl(repo: MavenRepositoryInfo): String {
if (Path.of(repo.url).isDirectory()) return Path.of(repo.url).toCanonicalPath()
try {
if (Path.of(repo.url).isDirectory()) return Path.of(repo.url).toCanonicalPath()
} catch (e: InvalidPathException) {
// Path.of() may throw InvalidPathException on Windows for URLs containing ':' character, continue with URI parsing
}

try {
val uri = URI(repo.url)
if (uri.scheme == null || uri.scheme.lowercase() == "file") {
Expand Down