Support multi-subnet fleets, explicit on-demand market type, terminate on shutdown#7
Merged
Alexander Chumakin (alexandrchumakin) merged 2 commits intoJul 17, 2026
Conversation
- subnet-id (and availability-zones-config subnetId) accepts several comma/whitespace-separated subnets; the EC2 Fleet gets one override per subnet x instance type, widening spot pools across AZs to reduce interruptions. RunInstances path tries subnets sequentially. - market-type accepts 'on-demand' explicitly and rejects invalid values (the old check compared an undefined field and never fired). - Pin InstanceInitiatedShutdownBehavior=terminate so OS-level shutdown safety nets terminate on-demand runners instead of leaving stopped instances with billed EBS volumes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Alexander Chumakin (alexandrchumakin)
requested review from
Alexander Demukh (alexander-demukh) and
Paige (paigethewen)
July 17, 2026 11:48
|
The diff is crazy here |
Alexander Demukh (alexander-demukh)
approved these changes
Jul 17, 2026
Alexander Chumakin (alexandrchumakin)
deleted the
achumakin/on-demand-multi-subnet
branch
July 17, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subnet-id(andsubnetIdinsideavailability-zones-config) accepts several comma/whitespace-separated subnets. The EC2 Fleet request gets one override per subnet × instance type so capacity/spot pools span multiple AZs; the RunInstances path tries subnets in sequence. Single-subnet callers are unchanged.market-typeacceptson-demandexplicitly, and invalid values now fail: the old check read an undefined field and never fired, so any typo silently launched on-demand.InstanceInitiatedShutdownBehavior=terminate. On-demand instances default tostop, so theshutdown -P +240safety net in orca-workflows start-runner would leave a stopped instance with a billed EBS volume; one-time spot already terminates, this makes on-demand match.Context: orca-workflows is switching CI runners from spot to on-demand — spot reclaims kill jobs mid-run with 'runner lost communication' (jcp-orca-agent-tests run 29570946157 lost its runner 7 minutes into the job; the serial console shows a hypervisor-initiated poweroff). The default-flip PR JetBrains/orca-workflows#177 depends on the terminate pin here.
dist/rebuilt with ncc. eslint has one pre-existingno-use-before-definefinding on main, unchanged here.After merge: re-point the
v2tag to pick this up, then merge JetBrains/orca-workflows#177.