Refactor compose container lifecycle delegate #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svastven
reviewed
Nov 19, 2025
compose/ui/ui-uikit/src/uikitMain/objc/CMPUIKitUtils/CMPUIKitUtils/CMPView.m
Show resolved
Hide resolved
svastven
approved these changes
Nov 20, 2025
mazunin-v-jb
approved these changes
Nov 21, 2025
| switch (self->_lifecycleState) { | ||
| case CMPComposeContainerLifecycleStateInitialized: | ||
| case CMPComposeContainerLifecycleStateStopped: | ||
| assert(false); |
There was a problem hiding this comment.
maybe we could either add a short comment on why these cases uses assert, or consider using NSAssert with an explanation? For the maintainability
Author
There was a problem hiding this comment.
Good catch. That's actually an incorrect assertion. It should check only the Initialized because Stopped is a valid state here because we're not canceling the scheduled work item.
mazunin-v-jb
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary refactoring before the https://youtrack.jetbrains.com/issue/CMP-8478/Implement-UIView-based-compose-injection-API
CMPViewControllerLifecycleDelegatetoCMPComposeContainerLifecycleDelegateas well as correspondingComposeContainerLifecycleDelegatein Kotlin code.CMPViewthat able to track visibility based on superview + window combination, similar to theCMPViewController.userInterfaceStyleDidChangeto monitor changes for various iOS versionsRelease Notes
N/A