forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 105
Allow specifying AWT AccessibleRole directly
#2577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
m-sasha
wants to merge
4
commits into
jb-main
Choose a base branch
from
m-sasha/support-awt-role
base: jb-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.awtRole experimental
AccessibleRole directly.AccessibleRole directly
MatkovIvan
reviewed
Nov 18, 2025
...se/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.desktop.kt
Show resolved
Hide resolved
igordmn
requested changes
Nov 18, 2025
Collaborator
igordmn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we need to wait for 1.10 branch.
Also needs 2 approvals.
| * | ||
| * @see SemanticsPropertyReceiver.role | ||
| */ | ||
| @ExperimentalComposeUiApi |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, create an issue for removing experimental with target = 1.13
MatkovIvan
approved these changes
Nov 19, 2025
igordmn
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow specifying
AccessibleRoles with no corresponding Compose role, addSemanticsPropertyReceiver.awtRole.Fixes https://youtrack.jetbrains.com/issue/CMP-9296/Support-specifying-AWT-AccessibleRole-in-semantics
Testing
Added a unit test, and tested manually with
This should be tested by QA
Release Notes
Features - Desktop
AccessibleRoledirectly viaSemanticsPropertyReceiver.awtRole.