Skip to content

Run pre-merge PR checks on GitHub Actions #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Oct 10, 2025
Merged

Run pre-merge PR checks on GitHub Actions #2414

merged 28 commits into from
Oct 10, 2025

Conversation

@MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Sep 18, 2025 •
edited
Loading

It adds all pre-merge checks that we currently have in TeamCity to GitHub Actions.

CMP-8945 Run web tests with the latest and the minimal supported version of browsers
CMP-8136 PR checks runs always by main teamcity config
CMP-5663 Run TeamCity automatically on user PR's after pressing "Approve and Run"

Also, ignored flaky tests (with TODO and follow-up tasks)

Release Notes

N/A

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch 12 times, most recently from 26b78ab to 4099ef0 Compare September 18, 2025 14:23
@MatkovIvan MatkovIvan changed the title CI checks experiment Run pre-merge PR checks in GitHub Actions Sep 18, 2025
@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch from 4099ef0 to 1cae97c Compare September 18, 2025 14:33
Schahen
Schahen approved these changes Sep 18, 2025
View reviewed changes
Copy link

@Schahen Schahen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no objections

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch 7 times, most recently from 82fc767 to a9ed1f2 Compare September 18, 2025 18:41
@MatkovIvan MatkovIvan marked this pull request as ready for review September 18, 2025 19:02
@MatkovIvan MatkovIvan requested review from igordmn and kropp September 18, 2025 19:02
@MatkovIvan MatkovIvan changed the title Run pre-merge PR checks in GitHub Actions Run pre-merge PR checks on GitHub Actions Sep 18, 2025
@MatkovIvan MatkovIvan closed this Oct 6, 2025
@MatkovIvan MatkovIvan reopened this Oct 6, 2025
@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch from 37f9324 to 077e2b7 Compare October 6, 2025 12:11
ASalavei
ASalavei reviewed Oct 6, 2025
View reviewed changes
@igordmn igordmn mentioned this pull request Oct 8, 2025
Merged
igordmn
igordmn requested changes Oct 8, 2025
View reviewed changes
igordmn
igordmn reviewed Oct 8, 2025
View reviewed changes
.github/actions/setup-prerequisites/action.yml
# These directories contain instrumented/transformed dependency jars which can be reconstructed relatively quickly.
gradle-home-cache-excludes: |
caches/jars-9
caches/transforms-3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, also remove TeamCity PR checks at the moment you merge this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jetbrains.team/p/ui/reviews/64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TC checks are expecteed to be red from this point (this branch)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version without moving iOS tests - https://jetbrains.team/p/ui/reviews/66

@igordmn
Copy link
Collaborator

igordmn commented Oct 8, 2025 •
edited
Loading

It is good to merge when we solve/verify the web and iOS issues (if it isn't reproduced anymore, consider it also verified, please rerun at least 5 times)

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch 2 times, most recently from cbf1188 to eaff02c Compare October 10, 2025 09:56
@MatkovIvan
Copy link
Member Author

MatkovIvan commented Oct 10, 2025 •
edited
Loading

Run Desktop Tests iOS Tests iOS Utils Tests iOS Instrumented Tests Web Chrome Tests Web Firefox Tests
#2414/1 ✅ ✅ ✅ ✅ ✅ ✅
#2414/2 ✅ ✅ ✅ ❌ ✅ ✅
#2414/3 ✅ ✅ ❌ ✅ ✅ ✅
#2414/4 ✅ ✅ ❌ ❌ ✅ ❌
#2414/5 ✅ ✅ ✅ ❌ ✅ ✅
#2443/1 ✅ ❌ ❌ ✅ ✅ ✅
#2443/2 ✅ ✅ ✅ ❌ ✅ ✅
#2443/3 ✅ ✅ ❌ ❌ ✅ ✅
#2443/4 ✅ ✅ ❌ ✅ ✅ ✅
#2443/5 ✅ ✅ ✅ ❌ ✅ ✅

Additionally ignored tests at the moment:

  • LazyGridSlotsReuseTest.differentContentTypes on Web (JS only)
  • SkikoParagraphTest on Web
  • SkiaParagraphIntrinsicsTest on Web
  • StringTest.directionality on Web
  • CfWA11YTest.changesMustBeBatched on Web (fails on latest firefox)
  • CfWA11YTest.changesMustBeAppliedDespiteConstantDebounceAfter1Second on Web (fails on latest firefox)
  • CfWA11YTest.noChangesFor1SecondTheDebounceShouldWork on Web (fails on latest firefox)
  • ComposeContainerLifecycleOwnerTest.allEvents - on Desktop
  • WindowTest > undecorated resizable window with unspecified size on Desktop
  • BasicInteractionTest.testBasicTextFieldToolbar on iOS

Failures

iOS Tests

  • ExposedDropdownMenuTest.edm_withScrolledContent x1

iOS Utils Tests

  • CMPViewControllerTests.testFullScreenPresentation x1
  • (launchSession) should not be nil. x3
  • Timeout x1

iOS Instrumented Tests

  • BasicInteractionTest.testBasicTextField* x3
  • Timeout x3

Web Firefox Tests

  • :compose:foundation:foundation:jsBrowserTest exited with errors (no details) x1

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/pr-gha-checks branch from eaff02c to 5630370 Compare October 10, 2025 12:55
@MatkovIvan MatkovIvan requested a review from igordmn October 10, 2025 13:00
@MatkovIvan
Copy link
Member Author

Decided to migrate iOS Utils Tests and iOS Instrumented Tests separately

@MatkovIvan MatkovIvan merged commit 8f52183 into jb-main Oct 10, 2025
32 of 33 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/pr-gha-checks branch October 10, 2025 13:39
@MatkovIvan MatkovIvan mentioned this pull request Oct 10, 2025
Merged
MatkovIvan added a commit that referenced this pull request Oct 17, 2025
@MatkovIvan @ASalavei
Move iOS Tests to GitHub actions (#2461)
9527f7d 
iOS part extracted from #2414

Fixes: [CMP-9065](https://youtrack.jetbrains.com/issue/CMP-9065) Move
iOS tests to GitHub actions

## Release Notes
N/A

---------

Co-authored-by: Andrei Salavei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kropp kropp kropp approved these changes

@igordmn igordmn igordmn approved these changes

@Schahen Schahen Schahen approved these changes

@ASalavei ASalavei ASalavei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MatkovIvan @igordmn @kropp @Schahen @ASalavei