run platform detection on the usenet and DDL import paths - #36
Merged
Conversation
The usenet path routed on whatever the search row carried, so a console ROM set that arrived with no platform_slug matched neither destination and was left in the download directory on a job reporting completed. The torrent path has run the full detection cascade all along. Pulled that cascade into resolvePlatform and called it from both paths rather than adding a second copy, since nzb.go already notes these two having drifted once before.
organizeDDLFile had the identical fallthrough: no cascade, so content that arrived with no platform_slug was left in staging on a job reporting completed. Vimm's Lair is a DDL source and its rows do carry slugs, which is what has kept this one out of sight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usenet and DDL import paths never ran platform detection, so a console ROM set that
arrives without a platform label on its search row downloads fine and then sits in staging
with its job marked completed. Only the torrent path had the cascade. I pulled it out of
organizeGame into resolvePlatform and call it from all three - the comment above
nzbDestPath already noted those two had drifted once before, which is what pointed me at
it.
I left the unknown-platform branch reporting status "completed" and only added a log line
there, since changing it touches retry semantics and the UI and seemed like your call
rather than mine.
Verified on my own instance: the same NZB that previously stranded with
Downloaded (unknown platform, left in staging)now resolves SNES from its files andlands in the ROM library.