Track downloads by infohash - #27
Merged
Merged
Conversation
JeremiahM37
added a commit
to vedhavyas/gamarr
that referenced
this pull request
Aug 19, 2026
JeremiahM37#27, JeremiahM37#28 and JeremiahM37#29 landed while this was open. Two collisions: - JeremiahM37#29's TestDownloadTorrentFileListScanDisabled still calls DownloadTorrent with the pre-JeremiahM37#27 five-argument signature, so main does not currently compile under test. Fixed here. - JeremiahM37#29's test and the two added by the previous commit both append to manager_test.go; kept both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A torrent job records only the release title, so the only handle back to the download is a fuzzy title match against the client's torrent list, matching when either string contains the other, lowercased. Real release names don't survive that. Two that missed for me:
Terraria (v1.4.5.0 + Bonus OST, MULTi9) [FitGirl Repack]against qBittorrent'sTerraria [FitGirl Repack]Papers, Please v1.2.70againstPapers.Please.v1.2.70.rarBoth jobs sat at
downloadingindefinitely while the download itself finished and got picked up by the completed-torrent watcher instead, leaving an extra orphaned row per grab. Matching in either direction also meansHitmanmatchesHitman.2.Gold.Edition-CODEX, so a job can attach itself to a different game's torrent.The infohash is already parsed out of the Prowlarr response and carried on the download request, it just never reaches the job. This stores it and matches on it where a row has one, falling back to the title for rows created before the change. It pairs with #26: once tracking works the job's platform is actually used, so a PC game tagged 4050 would file as Switch until that one lands too.