Skip to content

fix issue #57, now name="name" is possible #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix issue #57, now name="name" is possible #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/angular-validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ angular.module('angularValidator').directive('angularValidator', ['$injector', '

// This is the DOM form element
var DOMForm = angular.element(element)[0];
// and this is it's name. stored for later re-use.
// used to be retrived dynamically (via: element.form.name) but this comes with a negative angular effect:
// as soon as there is an input named "name", then angular will return that instead of the main form itself...
var main_form_name = angular.element(DOMForm).attr('name');

// an array to store all the watches for form elements
var watches = [];
Expand Down Expand Up @@ -180,7 +184,7 @@ angular.module('angularValidator').directive('angularValidator', ['$injector', '


// Only add validation messages if the form field is $dirty or the form has been submitted
if (scopeElementModel.$dirty || (scope[element.form.name] && scope[element.form.name].submitted)) {
if (scopeElementModel.$dirty || (scope[main_form_name] && scope[main_form_name].submitted)) {

if (scopeElementModel.$error.required) {
// If there is a custom required message display it
Expand Down Expand Up @@ -243,7 +247,7 @@ angular.module('angularValidator').directive('angularValidator', ['$injector', '


// Only add/remove validation classes if the field is $dirty or the form has been submitted
if (formField.$dirty || (scope[element.form.name] && scope[element.form.name].submitted)) {
if (formField.$dirty || (scope[main_form_name] && scope[main_form_name].submitted)) {
if (formField.$invalid) {
angular.element(element.parentNode).addClass('has-error');

Expand Down