Skip to content

Fixed Request with GET/HEAD method cannot have body bug #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
M97Chahboun merged 3 commits into from
Feb 25, 2025
+8 −3
Merged

Fixed Request with GET/HEAD method cannot have body bug #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6952f49
Handle null data in request body encoding
M97Chahboun Feb 24, 2025
fc48722
bump rocket client version
M97Chahboun Feb 25, 2025
6f52469
Update CHANGELOG for version 0.0.5: Fix GET/HEAD method body bug
M97Chahboun Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/rocket_client/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,9 @@
* Fixed bug on `request` method

# 0.0.4
* Support request retry

* Support request retry

# 0.0.5

* Fix `Request with GET/HEAD method cannot have body` bug
2 changes: 1 addition & 1 deletion packages/rocket_client/lib/src/rocket_client_base.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ class RocketClient {
String mapToParams = Uri(queryParameters: params ?? {}).query;
Uri url = Uri.parse("${this.url}/$endpoint?$mapToParams");
Request request = Request(method.name, url);
request.body = json.encode(data);
if (data != null) request.body = json.encode(data);
request.headers.addAll(headers);
final client = Client();
final retryClient = RetryClient(client,
Expand Down
2 changes: 1 addition & 1 deletion packages/rocket_client/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rocket_client
description: for making HTTP requests and handling responses.
version: 0.0.4
version: 0.0.5
repository: https://github.com/JahezAcademy/flutter_rocket/tree/dev/packages/rocket_client
issue_tracker: https://github.com/JahezAcademy/flutter_rocket/labels/rocket_client
homepage: https://github.com/JahezAcademy/flutter_rocket
Expand Down
Loading