[Omoboi-dev]

Summary

dev stopped compiling on 2026-10-18 when #1016 and #1011 left half-merged code in two files. CI failed at the typecheck from then on, so none of the PRs merged since were type checked or tested. This PR fixes the build and every failure the broken build was hiding.

Verified locally on Node 22 against Postgres, using the env from each workflow:

Check	Result
npm run typecheck	0 errors
npm run lint:check	0 errors (9 existing warnings)
npm run build	passes
npm run test:cov	127 suites, 1876 tests pass
check_coverage.js	branches 84.14%, functions 92.63%
check_test_match.js	all 127 files match
npm run openapi:generate	passes
npm run test:integration	39 suites, 343 tests pass
npm run test:e2e	12 suites, 64 tests pass

Build fixes

• admin-stats.service.ts: Fix/stress test bounds 404 logistics key rotation admin stats count #1016 pasted the pre-repository version of getStats into the current one. Restored the version from before Fix/stress test bounds 404 logistics key rotation admin stats count #1016. The distinct counts already live in AdminStatsRepository.
• update-vendor-profile.dto.ts: fix: resolve issues 939, 942, 943, and 946 #1011 switched to PartialType(CreateVendorProfileDto) (UpdateVendorProfileDto duplicates the create DTO by hand #939) but left the old class body below it. That body is removed.
• sep10.constants.ts and config.module.ts: ACCESS_TOKEN_TTL has no upper bound and no test #1077 was built on an old base. It deleted three SEP-10 constants and replaced the shared config schema with a stale inline copy that has no Joi import and no ignoreEnvFile. Both files are restored. Its real change (ACCESS_TOKEN_TTL max 86400) is now in config.schema.ts. Its TTL tests now check the real schema, and the two tests it deleted are back.
• escrow.service.ts:
  • Removed a duplicate encryptContact import.
  • Fix #912,913,914,915 #1007 called notifyCancelled, which never existed. The two refund cases now use notifyRefunded. The two cancel cases notify nobody, matching the existing cancel paths (there's no cancelled template).
• Missing imports: INestApplication and parseTrustProxy in main.ts, IsISO4217CurrencyCode in the account details DTO, and import type for StressTestResult.
• notifications.service.ts: dispatch has had no callers since fix: close remaining Stellar vendor dispatch path (#942, #943, #946) #1019, so it's removed. Its tracing spans move onto the buyer dispatch path so notification tracing isn't lost.

Runtime fixes

• logistics.module.ts: the app could not boot. The GiglClient factory (fix: resolve issues 1054, 1055, 1056, 1057 #1075) injected GiglLogisticsService, which injects GiglClient, so Nest hit a circular dependency. The factory now resolves the service through ModuleRef when it reads the token, so key rotation (Rotating the logistics key still does not change the key the carrier client sends #1054) still takes effect immediately.
• tracking-poll.worker.ts: restored the no-trackingId and unmapped-escrow guards and the tracking_poll.unmapped_escrow log, and removed the contractEscrowId! assertion. The repository query still does the filtering (The tracking poll does work it then throws away #960). The guards are a safety net.

Tests updated for intended behavior

Each of these changes was deliberate in its PR, but the PR never updated the tests:

• JwtGuard reads the secret only from ConfigService (fix(config): config/env hardening — closes #976 #977 #979 #980 #1032). Three controller specs now provide one, and the Prisma module mock gains get.
• GiglClient takes getApiToken and sends the token on each request (Fix/stress test bounds 404 logistics key rotation admin stats count #1016).
• No notification goes to a Stellar address (Notifications are still sent to Stellar addresses #946, fix: close remaining Stellar vendor dispatch path (#942, #943, #946) #1019). Specs that build the service by hand now supply a vendor profile or an encrypted buyer contact.
• Quiet polls advance the cursor with a getLatestLedger call (The poller cursor never moves while the contract is quiet #917, A paging token cursor still goes stale while the contract is quiet #1042). Lifecycle tests count getEvents requests.
• The audit log always passes a where (feat(audit): add filters, audit trail, and atomic DLQ replay #1015).
• findShippedWithTracking excludes unmapped escrows (The tracking poll does work it then throws away #960). Fixtures are mapped, and a new test covers the exclusion.
• /admin/credentials maps to admin.api_keys (fix: resolve issues 971, 972, 974, and 975 #1033).
• Phones are E.164 (fix: resolve issues 937, 938, 945, and 949 #1010), and preferredCurrency is ISO 4217 (Account details accept any currency and unbounded payment methods #1064).
• A vendor with no settings row defaults to email (Analytics says email notifications are off for every new vendor #943).
• The analytics repository test's time window now ends after the insert.

The other changed files are prettier reformatting of code the merges left unformatted. In those files, the only change besides whitespace is one redundant type cast removed by ESLint.

Not in this PR

• The Security Audit workflow fails on a new follow-redirects advisory (GHSA-8r9p-f939-6h3c). That needs a dependency upgrade.
• @IsISO4217CurrencyCode rejects USDC as a vendor's preferred currency. That follows Account details accept any currency and unbounded payment methods #1064 as written, but it may not be what we want for a USDC platform.