Fix fatal crash in in-app popup WebView initialization#1026
Closed
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Closed
Fix fatal crash in in-app popup WebView initialization#1026franco-zalamena-iterable wants to merge 1 commit intomasterfrom
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Conversation
Add explicit catch for AndroidRuntimeException in createWebViewSafely() to handle the case where the WebView package is being updated or is unavailable (WebViewFactory.getProvider throws InvocationTargetException wrapped in AndroidRuntimeException). Also catch Error for rare cases where native WebView libraries fail to load (e.g., UnsatisfiedLinkError). The dialog is gracefully dismissed instead of crashing the app. Fixes #1013 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
PR AnalysisProblem: The app crashes with Ideal fix plan:
What the PR did:
Assessment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AndroidRuntimeExceptionincreateWebViewSafely()to handle WebView provider failures (e.g., WebView package being updated or unavailable)Errorto handle rare native library loading failures (e.g.,UnsatisfiedLinkError)Test plan
🤖 Generated with Claude Code