Handle WebView render process crash gracefully#1020
Closed
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Closed
Handle WebView render process crash gracefully#1020franco-zalamena-iterable wants to merge 1 commit intomasterfrom
franco-zalamena-iterable wants to merge 1 commit intomasterfrom
Conversation
Add onRenderProcessGone handler to both IterableWebViewClient and IterableInboxMessageFragment's WebViewClient to prevent app crashes when the Chromium renderer process dies. The handler logs the event, cleans up the WebView, and returns true to absorb the crash. Fixes #954 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
PR AnalysisProblem: When the Chromium renderer process crashes (e.g., due to infinite loops or memory exhaustion), WebViews in the Iterable SDK do not handle the Ideal fix plan:
What the PR did:
Assessment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onRenderProcessGonehandler toIterableWebViewClientto prevent app crashes when the Chromium renderer process diesWebViewClientinIterableInboxMessageFragmentfor inbox message WebViewsdestroy(), and returntrueto absorb the crashTest plan
🤖 Generated with Claude Code