Fix hidden apps in the wishlist stats pop-up - #2355
Open
przemo20 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
Hidden appspop-up appears to list games that are no longer available for purchase but whose Steam store pages are still visible.I believe the pop-up should instead only include games whose store pages are no longer visible (i.e. items that appear as
(unavailable item)on the wishlist).For example,
Marvel's Guardians of the Galaxy: The Telltale Series(https://store.steampowered.com/app/579950/Marvels_Guardians_of_the_Galaxy_The_Telltale_Series/) is currently included in theHidden appslist even though its store page is still accessible (visible: true).With this change, that game is no longer treated as hidden. Instead, games whose store pages are actually unavailable (for example,
Deadpool, app 224060, which hasvisible: false) are included in the list.Guardians of the Galaxy JSON
Deadpool JSON
EDIT: Probably the variable names should be updated too. For example:
unlistedApps→hiddenApps.This is how the code looked for this before the rewrite: https://github.com/IsThereAnyDeal/AugmentedSteam/blob/v4.1.2/src/js/Content/Features/Store/Wishlist/FWishlistStats.ts