Fix Date#setDay validation for all 30-day months#492
Open
cuiweixie wants to merge 1 commit intoIoLanguage:masterfrom
Open
Fix Date#setDay validation for all 30-day months#492cuiweixie wants to merge 1 commit intoIoLanguage:masterfrom
cuiweixie wants to merge 1 commit intoIoLanguage:masterfrom
Conversation
IoDate_setDay only applied the 30-day guard to November (11), so April, June, and September accepted day 31 against the calendar. Apply the same bounds check to months 4, 6, 9, and 11. Add DateTest regression coverage and isLaunchScript runner for direct io DateTest.io runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IoDate_setDayonly applied the 30-day guard to November (month == 11), so April, June, and September were not validated as 30-day months and could acceptsetDay(31)incorrectly.Changes
1–30day assertion to months 4, 6, 9, and 11 (calendar 30-day months).DateTestregression:assertRaisesExceptionforsetDay(31)in each of those months, plusisLaunchScriptsoio DateTest.ioruns the suite.Testing