Skip to content

Propagate new TxBodyContent type #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Jimbo4350 wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

Propagate new TxBodyContent type #1309

Jimbo4350 wants to merge 25 commits into from
+1,028 −890

Conversation

@Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Nov 25, 2025

Changelog

- description: |
    Propagate new `TxBodyContent` type
# uncomment types applicable to the change:
  type:
  - compatible

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch 3 times, most recently from 559c0a2 to 0d78776 Compare November 27, 2025 15:21
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 84aa453 to dfdfae8 Compare December 5, 2025 15:22
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2025
View reviewed changes
cardano-cli/src/Cardano/CLI/EraBased/Transaction/Run.hs
Exp.TxMintValue $
Map.intersectionWith
(\assets wit -> (assets, BuildTxWith wit))
(\assets wit -> (assets, wit))

Check notice

Code scanning / HLint

Use (,) Note

cardano-cli/src/Cardano/CLI/EraBased/Transaction/Run.hs:1232:14-41: Suggestion: Use (,)
  
Found:
  \ assets wit -> (assets, wit)
  
Perhaps:
  (,)
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from dfdfae8 to b1b3b59 Compare December 16, 2025 19:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 16, 2025
View reviewed changes
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 9b1fff1 to 230492b Compare December 18, 2025 20:04
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 18a9731 to 3a2ce3f Compare December 22, 2025 20:48
@Jimbo4350 Jimbo4350 force-pushed the jordan/new-tx-body-content branch from 16b0451 to d1cb86e Compare December 24, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

@palas palas Awaiting requested review from palas palas will be requested when the pull request is marked ready for review palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Jimbo4350