-
Notifications
You must be signed in to change notification settings - Fork 390
[Enhance] Move pydantic model check to ut ci #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR moves the pydantic model validation check from the pre-commit hooks to the CI workflow, allowing the check to run during unit tests rather than locally on every commit.
Key Changes:
- Removed
pydantic-extra-checkhook from pre-commit configuration - Added a dedicated
pydantic_checkjob in the unit test workflow that runs before unit tests
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Removed the pydantic-extra-check hook that was previously executed on local commits |
.github/workflows/unit_test.yaml |
Added a new pydantic_check job that executes the pydantic validation script and configured unit_test job to depend on it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/unit_test.yaml
Outdated
| run: | | ||
| clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py |
Copilot
AI
Nov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML syntax error: Missing indentation for the run key. The run key should be indented at the same level as name (2 spaces more than steps), but it's currently at the wrong indentation level.
| run: | | |
| clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py | |
| run: | | |
| clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py |
.github/workflows/unit_test.yaml
Outdated
| - name: check pydantic BaseModel | ||
| run: | | ||
| clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py |
Copilot
AI
Nov 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing checkout step before running the pydantic check script. The job references .dev_scripts/test_pydantic.py which needs to be checked out from the repository first. Add - uses: actions/checkout@v3 before the run step, similar to how it's done in the unit_test job.
| - name: check pydantic BaseModel | |
| run: | | |
| clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py | |
| - uses: actions/checkout@v3 | |
| - name: check pydantic BaseModel | |
| run: | | |
| clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py |
6263b30 to
7675971
Compare
7675971 to
a7f93c2
Compare
No description provided.