Skip to content

Conversation

@HAOCHENYE
Copy link
Collaborator

No description provided.

@HAOCHENYE HAOCHENYE requested a review from Copilot November 25, 2025 10:02
Copilot finished reviewing on behalf of HAOCHENYE November 25, 2025 10:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR moves the pydantic model validation check from the pre-commit hooks to the CI workflow, allowing the check to run during unit tests rather than locally on every commit.

Key Changes:

  • Removed pydantic-extra-check hook from pre-commit configuration
  • Added a dedicated pydantic_check job in the unit test workflow that runs before unit tests

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.pre-commit-config.yaml Removed the pydantic-extra-check hook that was previously executed on local commits
.github/workflows/unit_test.yaml Added a new pydantic_check job that executes the pydantic validation script and configured unit_test job to depend on it

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 24 to 25
run: |
clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAML syntax error: Missing indentation for the run key. The run key should be indented at the same level as name (2 spaces more than steps), but it's currently at the wrong indentation level.

Suggested change
run: |
clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py
run: |
clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py

Copilot uses AI. Check for mistakes.
Comment on lines 23 to 25
- name: check pydantic BaseModel
run: |
clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing checkout step before running the pydantic check script. The job references .dev_scripts/test_pydantic.py which needs to be checked out from the repository first. Add - uses: actions/checkout@v3 before the run step, similar to how it's done in the unit_test job.

Suggested change
- name: check pydantic BaseModel
run: |
clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py
- uses: actions/checkout@v3
- name: check pydantic BaseModel
run: |
clusterx run --image $IMAGE --no-env python .dev_scripts/test_pydantic.py

Copilot uses AI. Check for mistakes.
@HAOCHENYE HAOCHENYE force-pushed the yehc/move-pydantic-to-ut branch from 6263b30 to 7675971 Compare November 25, 2025 10:09
@HAOCHENYE HAOCHENYE force-pushed the yehc/move-pydantic-to-ut branch from 7675971 to a7f93c2 Compare November 25, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants