[Fix] Fix Division-by-zero error when warmup steps set the same as total steps #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nil0x9
force-pushed
the
linty/dev-fix-lr-scheduler-corner-case
branch
from
416c867 to
85ed80e
Compare
nil0x9
force-pushed
the
linty/dev-fix-lr-scheduler-corner-case
branch
from
85ed80e to
0980ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if user set warmup steps to be the same as total steps (which is deemed valid) for
cosineorlinearLR scheduler, adivision-by-zeroerror will be thrown. This PR fixes this case (along w/ some lint issues).