Skip to content

move files from sources that are not used#2056

Closed
masinter wants to merge 1 commit intomasterfrom
lmm-obsolete-unused-sources
Closed

move files from sources that are not used#2056
masinter wants to merge 1 commit intomasterfrom
lmm-obsolete-unused-sources

Conversation

@masinter
Copy link
Copy Markdown
Member

@masinter masinter commented Mar 6, 2025

the files moved are not loaded in any loadup or EVAL@COMPILE or otherwise referenced.

@masinter masinter force-pushed the lmm-obsolete-unused-sources branch from 3935983 to 510516e Compare March 6, 2025 15:22
@nbriggs
Copy link
Copy Markdown
Contributor

nbriggs commented Mar 7, 2025

Uh, "not used" in a loadup doesn't mean nobody ever needs to load them. Nobody will ever need to load SEDIT-DEBUG if they're working on SEDIT ??

@masinter
Copy link
Copy Markdown
Member Author

masinter commented Mar 7, 2025

SEDIT-DEBUG is interesting -- a set of utilities, e.g., changing FNS to FUNCTIONS.
There are no mentions of SEDIT-DEBUG anywhere (grep -lri sedit-debug ) in any documentation or other files.

I could see moving the file to the "internal" directory instead of "obsolete/sources/" but it is unlikely to be useful.

@rmkaplan
Copy link
Copy Markdown
Contributor

rmkaplan commented Mar 7, 2025 via email

@masinter masinter marked this pull request as draft March 10, 2025 18:32
@masinter
Copy link
Copy Markdown
Member Author

should triage and distinguish between 'unused' and 'obsolete'.

@masinter
Copy link
Copy Markdown
Member Author

the 'obsolete' directory has been removed from master (copied to Interlisp/history repo).
So any files that here are "move to obsolete" here should be turned into an issue "delete if unused" and a bigger net to catch files that are actually used or mentioned anywhere.

In the meanwhile, closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants