fix: hard-code ports in webhook-service

README.md

@@ -117,9 +117,6 @@ CRDs are located in `chart/crds/` and are installed automatically. The API group
 |-----------|-------------|---------|
 | `webhooks.enabled` | Enable or disable all Kubernetes admission webhook resources (ValidatingWebhookConfiguration, webhook Service, TLS Certificate, Issuer, and NetworkPolicy). Also sets the `ENABLE_WEBHOOKS` env var on the controller. | `true` |
 | `webhookService.type` | Service type for the webhook endpoint | `ClusterIP` |
-| `webhookService.ports[0].port` | Service port | `443` |
-| `webhookService.ports[0].targetPort` | Container target port | `9443` |
-| `webhookService.ports[0].protocol` | Protocol | `TCP` |
 
 ### TLS Certificates (cert-manager)
 

mise.toml

@@ -7,6 +7,6 @@ helm = "4.0.4"
 [tasks.setup-helm-plugins]
 description = "Install all needed helm plugins needed for development"
 run = [
-  "helm plugin install https://github.com/losisin/helm-values-schema-json.git --verify=false",
-  "helm plugin install https://github.com/helm-unittest/helm-unittest.git --verify=false",
+  "helm plugin install https://github.com/losisin/helm-values-schema-json.git --verify=false 2>/dev/null || helm plugin update schema",
+  "helm plugin install https://github.com/helm-unittest/helm-unittest.git --verify=false 2>/dev/null || helm plugin update unittest",
 ]

templates/webhook-service.yaml

@@ -11,5 +11,7 @@ spec:
     control-plane: controller-manager
     {{- include "git-hubby.selectorLabels" . | nindent 4 }}
   ports:
-  {{- .Values.webhookService.ports | toYaml | nindent 2 }}
+    - port: 443
+      protocol: TCP
+      targetPort: webhook-server
 {{- end }}

tests/services_test.yaml

@@ -43,7 +43,7 @@ tests:
           value: 443
       - equal:
           path: spec.ports[0].targetPort
-          value: 9443
+          value: webhook-server
       - equal:
           path: spec.selector.control-plane
           value: controller-manager

values.schema.json

@@ -232,23 +232,6 @@
         "webhookService": {
             "type": "object",
             "properties": {
-                "ports": {
-                    "type": "array",
-                    "items": {
-                        "type": "object",
-                        "properties": {
-                            "port": {
-                                "type": "integer"
-                            },
-                            "protocol": {
-                                "type": "string"
-                            },
-                            "targetPort": {
-                                "type": "integer"
-                            }
-                        }
-                    }
-                },
                 "type": {
                     "type": "string"
                 }

values.yaml

@@ -63,10 +63,6 @@ serviceAccount:
   create: true
   name: ""
 webhookService:
-  ports:
-  - port: 443
-    protocol: TCP
-    targetPort: 9443
   type: ClusterIP
 servingCert:
   # duration: 2160h0m0s