Skip to content

ENH: Clean up gerrit code review system leftovers #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged

ENH: Clean up gerrit code review system leftovers #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Utilities/GitSetup/config.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,3 @@
[stage]
#url = git://public.kitware.com/stage/Project.git
#pushurl = [email protected]:stage/Project.git

[gerrit]
#project = Project
site = https://review.source.kitware.com
# pushurl placeholder "$username" is literal
pushurl = [email protected]:Project
73 changes: 0 additions & 73 deletions Utilities/GitSetup/git-gerrit-push
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions Utilities/GitSetup/setup-git-aliases
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ git config alias.pr-clean '!git checkout master ; git for-each-ref refs/heads/pr
# Alias to push the current topic branch to GitHub
git config alias.review-push "!bash Utilities/GitSetup/git-review-push"

git config alias.gerrit-push \
"!bash -c 'echo \\\"git gerrit-push\\\" is deprecated. Please use \\\"git review-push\\\" instead.'"

# Useful alias to see what commits are on the current branch with respect to
# upstream/master
git config alias.prepush 'log --graph --stat upstream/master..'
13 changes: 0 additions & 13 deletions Utilities/SetupForDevelopment.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,6 @@ git config branch.master.rebase true
git config rebase.stat true
git config branch.master.rebase true

# Disable old Gerrit hooks
hook=$(git config --get hooks.GerritId) &&
if "$hook"; then
echo '
ITK has migrated from Gerrit to GitHub for code reviews.

Disabling the GerritId hook that adds a "Change-Id" footer to commit
messages for interaction with Gerrit. Also, removing the "gerrit" remote.' &&
git config hooks.GerritId false
git config --get remote.gerrit.url > /dev/null && \
git remote remove gerrit
fi

# Record the version of this setup so Hooks/pre-commit can check it.
SetupForDevelopment_VERSION=1
git config hooks.SetupForDevelopment ${SetupForDevelopment_VERSION}
Loading