fix(OutputImage): support information-only image outputs#1545
Open
vboussot wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bufferedRegion.sizewhile preserving thelargest possible image
sizeContext
downsample_bin_shrink(..., information_only=True)callsUpdateOutputInformation()and intentionally produces output metadata withoutallocating a pixel buffer.
OutputImagecurrently aborts when that legitimatebuffer has zero bytes. After removing the abort, the Python runtime also needs
to reshape data from the buffered region rather than the largest possible
region; otherwise it attempts to reshape an empty array to the logical image
size.
This breaks the metadata pre-pass used by
itkwasm-downsample-cucim==0.2.0for Gaussian and bin-shrink downsampling.
Downstream report: fideus-labs/ngff-zarr#577
Validation
itkPipelineMemoryIOTest: passedclang-format --dry-run --Werrortarget was blocked by an unavailable pre-existing external test object:
TransformSequence.h5installed
setup because the local Chrome instance exited before creating a session
🤖 Generated with Claude Code