Skip to content

Improve Git repository authentication handling #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylangovender wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve Git repository authentication handling #356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
840715e
Use pipe instead of forward slash as delimiter for GIT_REPOSITORY
dylangovender Jan 27, 2026
751df1b
Cater for git repos from bitbucket instances
dylangovender Jan 29, 2026
6530534
Neaten indentation
dylangovender Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions base/scripts/onyxia-init.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,14 @@ if command -v git &>/dev/null; then
fi
if [[ -n "$GIT_REPOSITORY" ]]; then
if [[ -n "$GIT_PERSONAL_ACCESS_TOKEN" ]]; then
REPO_DOMAIN=`echo "$GIT_REPOSITORY" | awk -F/ '{print $3}'`
if [ $REPO_DOMAIN = "github.com" ]; then
GIT_REPOSITORY=`echo $GIT_REPOSITORY | sed "s/$REPO_DOMAIN/$GIT_PERSONAL_ACCESS_TOKEN@$REPO_DOMAIN/"`
REPO_DOMAIN=$(echo "$GIT_REPOSITORY" | awk -F/ '{print $3}')
if [ "$REPO_DOMAIN" = "github.com" ]; then
GIT_REPOSITORY=$(echo "$GIT_REPOSITORY" | sed "s|$REPO_DOMAIN|$GIT_PERSONAL_ACCESS_TOKEN@$REPO_DOMAIN|")
GIT_REPOSITORY=$(echo "$GIT_REPOSITORY" | sed "s|$REPO_DOMAIN|$GIT_PERSONAL_ACCESS_TOKEN@$REPO_DOMAIN|")
Copy link
Contributor

@ihiverlet ihiverlet Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, It looks like this line is duplicated from above

elif echo "$GIT_REPOSITORY" | grep -qi "bitbucket"; then
Copy link
Contributor

@ihiverlet ihiverlet Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should check the REPO_DOMAIN here instead of the repository

GIT_REPOSITORY=$(echo "$GIT_REPOSITORY" | sed "s|$REPO_DOMAIN|$GIT_USER_NAME:$GIT_PERSONAL_ACCESS_TOKEN@$REPO_DOMAIN|")
else
GIT_REPOSITORY=`echo $GIT_REPOSITORY | sed "s/$REPO_DOMAIN/oauth2:$GIT_PERSONAL_ACCESS_TOKEN@$REPO_DOMAIN/"`
GIT_REPOSITORY=$(echo "$GIT_REPOSITORY" | sed "s|$REPO_DOMAIN|oauth2:$GIT_PERSONAL_ACCESS_TOKEN@$REPO_DOMAIN|")
fi
fi

Expand Down