Skip to content

feat/tc-derivatives-endpoints#627

Merged
ThomasRalee merged 1 commit intodevfrom
feat/tc-derivative-endpoints-v2
Mar 19, 2026
Merged

feat/tc-derivatives-endpoints#627
ThomasRalee merged 1 commit intodevfrom
feat/tc-derivative-endpoints-v2

Conversation

@Frederick-88
Copy link
Copy Markdown
Collaborator

@Frederick-88 Frederick-88 commented Mar 19, 2026

v2 update based on indexer/contract update

Summary by CodeRabbit

  • New Features

    • Added optional accountAddress parameter for filtering orders, trades, and order history queries across REST and streaming APIs.
    • Extended RFQ quote types with minFillQuantity and makerSubaccountNonce fields for enhanced quote data.
    • Added cid field to derivative limit orders for improved order tracking.
  • Chores

    • Updated indexer protocol buffer dependency to latest version.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 994e3c9a-b60e-4eb6-8b9d-6b0f8f1de353

📥 Commits

Reviewing files that changed from the base of the PR and between 3d4b9f2 and cc5b1d7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • packages/sdk-ts/package.json
  • packages/sdk-ts/src/client/indexer/grpc/IndexerGrpcTcDerivativesApi.ts
  • packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/IndexerGrpcTcDerivativesStreamV2.ts
  • packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcRfqTransformer.ts
  • packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcTcDerivativesTransformer.ts
  • packages/sdk-ts/src/client/indexer/types/rfq.ts
  • packages/sdk-ts/src/client/indexer/types/tc-derivatives.ts

📝 Walkthrough

Walkthrough

This PR updates the Injective SDK TypeScript package with a bumped dependency on the indexer-proto-ts-v2, extends API and streaming methods to accept optional accountAddress filtering parameters, and adds new fields (cid, minFillQuantity, makerSubaccountNonce) to RFQ and derivatives types with corresponding transformer mappings.

Changes

Cohort / File(s) Summary
Dependency Update
packages/sdk-ts/package.json
Bumped @injectivelabs/indexer-proto-ts-v2 from 1.18.9 to 1.18.10.
API Methods Enhancement
packages/sdk-ts/src/client/indexer/grpc/IndexerGrpcTcDerivativesApi.ts, packages/sdk-ts/src/client/indexer/grpc_stream/streamV2/IndexerGrpcTcDerivativesStreamV2.ts
Added optional accountAddress parameter to fetchOrdersHistory, fetchTradesHistory, fetchOrders (REST API) and corresponding streamOrdersHistory, streamTrades, streamOrders (streaming) methods, conditionally setting it on gRPC requests.
Transformer Logic Updates
packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcRfqTransformer.ts, packages/sdk-ts/src/client/indexer/transformers/IndexerGrpcTcDerivativesTransformer.ts
Extended RFQ transformers to map minFillQuantity and makerSubaccountNonce fields; added cid field mapping to derivatives transformer.
Type Definitions
packages/sdk-ts/src/client/indexer/types/rfq.ts, packages/sdk-ts/src/client/indexer/types/tc-derivatives.ts
Added makerSubaccountNonce: number and minFillQuantity: string fields to RFQQuoteType and RFQProcessedQuoteType; added cid: string field to TcDerivativeLimitOrder and reordered existing fields.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 The SDK hops forward with fields anew,
accountAddress filters, both REST and stream too!
RFQs gain nonces and minimum fills so bright,
Derivatives wear cid badges of delight! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/tc-derivative-endpoints-v2
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@socket-security
Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedglob@​11.0.3998510050100

View full report

@ThomasRalee ThomasRalee merged commit b0c2390 into dev Mar 19, 2026
4 of 5 checks passed
@ThomasRalee ThomasRalee deleted the feat/tc-derivative-endpoints-v2 branch March 19, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants