Skip to content

chore: Replace Sentry-Dynamic by SentrySPM - #209

Merged
valentinperignon merged 2 commits into
masterfrom
fix/sentry-spm
Nov 16, 2026
Merged

valentinperignon merged 2 commits into
masterfrom
fix/sentry-spm

Conversation

@valentinperignon

Copy link
Copy Markdown
Member

The Apple Distribution certificate of Sentry is revoked: getsentry/sentry-cocoa#9633

Copilot AI balanced review requested due to automatic review settings November 16, 2026 09:30
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The dependency range permits Sentry 9.8.0, whose unsafe build flags prevent versioned SwiftPM consumers from building, and three committed module maps contain developer-specific absolute paths that break resolution in other workspaces.

1 open issue
What changed in this PR

This PR switches InfomaniakCore to Sentry’s source-built Swift Package Manager product to avoid the binary framework certificate-validation failures reported in getsentry/sentry-cocoa#9633.

Changes:

  • Replaces Sentry-Dynamic with SentrySPM.
  • Updates five source files to import SentrySwift.
  • Adds generated dependency module maps and framework Info.plists.
File Description
Sources/​InfomaniakCore/​Tracking/​SentryDebug.swift Updates the tracking import to SentrySwift.
Sources/​InfomaniakCore/​Networking/​RequestContextIdAdaptor.swift Updates the request-context import.
Sources/​InfomaniakCore/​Networking/​ApiFetcher.swift Updates the API fetcher import.
Sources/​InfomaniakCore/​DeeplinkService/​DeeplinkService.swift Updates the deep-link service import.
Sources/​InfomaniakCore/​Account/​KeychainHelper.swift Updates the keychain helper import.
Package.swift Selects the SentrySPM dependency product.
Derived/​ModuleMaps/​InfomaniakCoreDB-deps.modulemap Adds generated database dependency paths.
Derived/​ModuleMaps/​InfomaniakCore-deps.modulemap Adds generated Sentry dependency paths.
Derived/​ModuleMaps/​DeviceAssociation-deps.modulemap Adds generated Sentry dependency paths.
Derived/​InfoPlists/​InfomaniakCoreDB-Info.plist Adds generated database framework metadata.
Derived/​InfoPlists/​InfomaniakCore-Info.plist Adds generated core framework metadata.
Derived/​InfoPlists/​DeviceAssociation-Info.plist Adds generated device-association framework metadata.

Review effort: Balanced

Comment thread Package.swift Resolved
@valentinperignon
valentinperignon merged commit 7ffc943 into master Nov 16, 2026
12 checks passed
@valentinperignon
valentinperignon deleted the fix/sentry-spm branch November 16, 2026 09:46
PhilippeWeidmann added a commit that referenced this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants