Repository navigation
chore: Replace Sentry-Dynamic by SentrySPM - #209
Merged
Merged
Conversation
valentinperignon
force-pushed
the
fix/sentry-spm
branch
from
November 16, 2026 09:31
91587bc to
e856ed0
Compare
|
There was a problem hiding this comment.
🟡 Changes recommended
The dependency range permits Sentry 9.8.0, whose unsafe build flags prevent versioned SwiftPM consumers from building, and three committed module maps contain developer-specific absolute paths that break resolution in other workspaces.
1 open issue
What changed in this PR
This PR switches InfomaniakCore to Sentry’s source-built Swift Package Manager product to avoid the binary framework certificate-validation failures reported in getsentry/sentry-cocoa#9633.
Changes:
- Replaces
Sentry-DynamicwithSentrySPM. - Updates five source files to import
SentrySwift. - Adds generated dependency module maps and framework Info.plists.
| File | Description |
|---|---|
Sources/InfomaniakCore/Tracking/SentryDebug.swift |
Updates the tracking import to SentrySwift. |
Sources/InfomaniakCore/Networking/RequestContextIdAdaptor.swift |
Updates the request-context import. |
Sources/InfomaniakCore/Networking/ApiFetcher.swift |
Updates the API fetcher import. |
Sources/InfomaniakCore/DeeplinkService/DeeplinkService.swift |
Updates the deep-link service import. |
Sources/InfomaniakCore/Account/KeychainHelper.swift |
Updates the keychain helper import. |
Package.swift |
Selects the SentrySPM dependency product. |
Derived/ModuleMaps/InfomaniakCoreDB-deps.modulemap |
Adds generated database dependency paths. |
Derived/ModuleMaps/InfomaniakCore-deps.modulemap |
Adds generated Sentry dependency paths. |
Derived/ModuleMaps/DeviceAssociation-deps.modulemap |
Adds generated Sentry dependency paths. |
Derived/InfoPlists/InfomaniakCoreDB-Info.plist |
Adds generated database framework metadata. |
Derived/InfoPlists/InfomaniakCore-Info.plist |
Adds generated core framework metadata. |
Derived/InfoPlists/DeviceAssociation-Info.plist |
Adds generated device-association framework metadata. |
Review effort: Balanced
PhilippeWeidmann
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




The Apple Distribution certificate of Sentry is revoked: getsentry/sentry-cocoa#9633