Skip to content

feat(security): Harden shared file writing - #205

Merged
adrien-coye merged 6 commits into
masterfrom
feat/shared-writing-hardenning
Aug 14, 2026
Merged

adrien-coye merged 6 commits into
masterfrom
feat/shared-writing-hardenning

Conversation

@adrien-coye

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens kDrive shared-file handoff through validation, limits, safer paths, and tests.

Changes:

  • Validates file counts, names, types, and handoff directories.
  • Centralizes file-sharing constants.
  • Adds security-focused unit tests.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
GroupContainerService.swift Adds validation and cleanup during file copying.
DeeplinkService.swift Adds shared constants and file-count limits.
UTGroupContainerService.swift Tests valid writes and rejection cases.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@PhilippeWeidmann PhilippeWeidmann left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit pick 🙏

@sonarqubecloud

Copy link
Copy Markdown

@adrien-coye
adrien-coye merged commit e667ed3 into master Aug 14, 2026
12 checks passed
@adrien-coye
adrien-coye deleted the feat/shared-writing-hardenning branch August 14, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants