Repository navigation
fix: Catch multi percent encode - #204
Conversation
bd1b83c to
85cef86
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Triple-percent-encoded traversal can still bypass the new validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Updates safe path extraction to reject double-percent-encoded traversal and control characters.
Changes:
- Validates separators and control characters after URL decoding.
- Adds regression tests for double-encoded traversal and controls.
File summaries
| File | Description |
|---|---|
Sources/InfomaniakCore/Extensions/String+Extension.swift |
Strengthens decoded path-component validation. |
Tests/InfomaniakCoreTests/Extensions/UTString+SafePath.swift |
Adds encoded traversal and control-character tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
There was a problem hiding this comment.
🟢 Ready to approve
The focused validation change correctly addresses the encoded-separator bypass and is supported by relevant regression tests.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
85cef86 to
b5e3869
Compare
There was a problem hiding this comment.
🟢 Ready to approve
The bounded validation closes the nested-encoding bypass and is covered by focused regression tests.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
b5e3869 to
25cf380
Compare
|



No description provided.