Skip to content

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Nov 6, 2025

Proposed Changes

To avoid having org.apache.arrow.memory.BaseAllocator throw IllegalStateExceptions this adds two control points for making sure the FlightStream using the BaseAllocator is closed correctly.

In FlightSqlClient

  • Keep track of autocloseable FlightStream and close them when FlightSqlClient.close() gets called.
  • In the FlightSqlIterator call FlightStream.close() once FlightStream.next() returns false.
  • One E2E test covers the first solution.

TODO - a couple of more tests.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.48%. Comparing base (240309c) to head (5f2328b).

Files with missing lines Patch % Lines
...m/influxdb/v3/client/internal/FlightSqlClient.java 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   87.47%   87.48%   +0.01%     
==========================================
  Files          20       20              
  Lines        1261     1286      +25     
  Branches      204      207       +3     
==========================================
+ Hits         1103     1125      +22     
- Misses         74       76       +2     
- Partials       84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@karel-rehor karel-rehor marked this pull request as ready for review November 7, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants