fix: arrow BaseAllocator is reporting memory leaks #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
To avoid having
org.apache.arrow.memory.BaseAllocatorthrowIllegalStateExceptions this adds two control points for making sure theFlightStreamusing theBaseAllocatoris closed correctly.In
FlightSqlClientFlightStreamand close them whenFlightSqlClient.close()gets called.FlightSqlIteratorcallFlightStream.close()onceFlightStream.next()returns false.TODO - a couple of more tests.
Checklist