Skip to content

ci: dynamically allow DMV git tarball builds #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoroctaviano merged 1 commit into from
Aug 14, 2026
Merged

ci: dynamically allow DMV git tarball builds #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/deploy-to-firebase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ jobs:
env:
DMV_USE_GIT: ${{ steps.dmv.outputs.use_git }}
DMV_REF: ${{ steps.dmv.outputs.ref }}
DMV_SHA: ${{ steps.dmv.outputs.sha }}
run: |
set -euo pipefail
if [ "${DMV_USE_GIT}" = "true" ]; then
Expand All @@ -68,6 +69,19 @@ jobs:
;;
esac
pnpm pkg set 'dependencies["dicom-microscopy-viewer"]'"=github:ImagingDataCommons/dicom-microscopy-viewer#${DMV_REF}"
# Dynamically allow builds for the resolved tarball URL so pnpm's
# dependency status check passes during `pnpm run build`
TARBALL_KEY="dicom-microscopy-viewer@https://codeload.github.com/ImagingDataCommons/dicom-microscopy-viewer/tar.gz/${DMV_SHA}"
node -e "
const fs = require('fs');
const content = fs.readFileSync('pnpm-workspace.yaml', 'utf8');
// Insert the tarball allowBuilds entry after 'dicom-microscopy-viewer: true'
const updated = content.replace(
/(allowBuilds:[\s\S]*?dicom-microscopy-viewer: true)/,
\"\$1\\n '\" + process.argv[1] + \"': true\"
);
fs.writeFileSync('pnpm-workspace.yaml', updated);
" "${TARBALL_KEY}"
pnpm install --no-frozen-lockfile --ignore-scripts
else
pnpm install --frozen-lockfile --ignore-scripts
Expand Down
1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ strictPeerDependencies: false
allowBuilds:
core-js: true
core-js-pure: true
# For npm-published versions; git tarball URLs are added dynamically by CI
dicom-microscopy-viewer: true

overrides:
Expand Down