Ticket 7914 - pull latest instrument scripts master #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Tom-Willemsen
requested changes
Oct 17, 2025
There was a problem hiding this comment.
- Please fix remaining ruff error (which is just imports in wrong order, and can be auto-fixed).
- Can you add something to https://isiscomputinggroup.github.io/ibex_developers_manual/scripting/instrument-scripts.html about this setup, expected branches, what we decided the auto-update implementation should look like, etc. Or add it to https://github.com/ISISNeutronMuon/InstrumentScripts/wiki and link through to it much more clearly from our manual.
installation_and_upgrade/ibex_install_utils/tasks/server_tasks.py
Outdated
Show resolved
Hide resolved
|
|
||
| @task("Set up shared instrument scripts library") | ||
| @task("Merge master into local shared instrument scripts library") | ||
| def update_shared_scripts_repository(self) -> None: |
There was a problem hiding this comment.
I think we need a clearer prompt to explicitly inform scientists that their InstrumentScripts library has been updated. It is nominally maintained by scientists with oversight from us, but we do need to make sure they get told when it has been updated.
There was a problem hiding this comment.
ok, I was thinking to make it very explicit prompt to a developer that they need to tell a scientist they've done this. But maybe that's "obvious", any time we go and fiddle with instrument scripts.
Tom-Willemsen
approved these changes
Oct 20, 2025
Tom-Willemsen
deleted the
Ticket7914_pull_latest_instrument_scripts_master
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ticket for details