Extract the stage loop into openTEPES_ProblemSolvingStageIter#129
Open
erikfilias wants to merge 3 commits into
Open
Extract the stage loop into openTEPES_ProblemSolvingStageIter#129erikfilias wants to merge 3 commits into
erikfilias wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Move the per-stage solve loop out of openTEPES_run (in openTEPES.py) into a new module openTEPES_ProblemSolvingStageIter.py, exposing it as a function StageIterativeSolving.
openTEPES.py still builds the objective and the investment constraints, sets First_st / Last_st and the empty pDuals, and then calls the new driver. The driver holds the (period, scenario, stage) loop — which activates one stage's load levels, builds that stage's operation constraints, and calls ProblemSolving — plus the post-loop work that rebuilds the full stage and load-level sets, reactivates every constraint, and restores the scenario probabilities.
Why
This continues the solver-layer split that already produced …Persistent.py, …Tuning.py and …DualExtraction.py. The stage loop was the last large piece still inlined in openTEPES_run. Pulling it out gives the later re-solve and decomposition drivers a single place to call the stage loop from, and makes openTEPES_run short enough to read at a glance.
Also in this PR