Add finalize dref api #2558
Draft
Add finalize dref api #2558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudip-khanal
force-pushed
the
feat/update-dref-status
branch
2 times, most recently
from
89a6cb8 to
7bebad0
Compare
sudip-khanal
force-pushed
the
feat/add-finalize-dref-api
branch
from
9384f6a to
6745b93
Compare
susilnem
force-pushed
the
feat/update-dref-status
branch
2 times, most recently
from
8de1330 to
9d7c227
Compare
Base automatically changed from
feat/update-dref-status
to
project/dref-translation
October 7, 2025 07:20
sudip-khanal
force-pushed
the
feat/add-finalize-dref-api
branch
from
6745b93 to
55d133b
Compare
Rup-Narayan-Rajbanshi
approved these changes
Oct 9, 2025
susilnem
requested changes
Oct 10, 2025
susilnem
requested changes
Oct 14, 2025
thenav56
requested changes
Oct 16, 2025
main/lock.py
Outdated
|
|
||
| OPERATION_LEARNING_SUMMARY = _BASE + "-operation-learning-summary-{0}" | ||
| OPERATION_LEARNING_SUMMARY_EXPORT = _BASE + "-operation-learning-summary-export-{0}" | ||
| DREF_TRANSLATION = _BASE + "-dref-translation-{0}" |
There was a problem hiding this comment.
we also need to add model table name in the key...
There was a problem hiding this comment.
Change DREF_TRANSLATION to MODEL_TRANSLATION
"-{db_table_name}-translation-{0}"
dref/utils.py
Outdated
| """ | ||
| Trigger translation task with Redis lock. | ||
| """ | ||
| with redis_lock(key=RedisLockKey.DREF_TRANSLATION, id=instance.pk) as acquired: |
There was a problem hiding this comment.
The lock needs to be in the job function, not the trigger function
There was a problem hiding this comment.
Any reason on why we are modifying existing migration file?
How we are planning to run this in local and already deployed instances
dref/serializers.py
Outdated
| to = {u.email for u in validated_data["users"]} | ||
| else: | ||
| to = None | ||
| # set original language |
dref/serializers.py
Outdated
| def create(self, validated_data): | ||
| dref = validated_data["dref"] | ||
| language = validated_data.get("original_language") | ||
| if language != dref.original_language and language != dref.translation_module_original_language: |
dref/serializers.py
Outdated
| # else copy from dref | ||
| dref = validated_data["dref"] | ||
| language = validated_data.get("original_language") | ||
| if language != dref.original_language and language != dref.translation_module_original_language: |
dref/views.py
Outdated
| raise serializers.ValidationError(gettext("Cannot be finalized because it is already %s") % dref.get_status_display()) | ||
| if not is_translation_complete(dref): | ||
| trigger_translation(dref) | ||
| raise serializers.ValidationError(gettext("Translation is not completed. Please try again later.")) |
There was a problem hiding this comment.
Let's add something like "the translation is triggered, so wait and try again" @udaynwa
dref/views.py
Outdated
| if dref.status in [Dref.Status.FINALIZED, Dref.Status.APPROVED]: | ||
| raise serializers.ValidationError(gettext("Cannot be finalized because it is already %s") % dref.get_status_display()) | ||
| if not is_translation_complete(dref): | ||
| trigger_translation(dref) |
There was a problem hiding this comment.
Are we triggering related tables translation in another PR?
susilnem
requested changes
Oct 29, 2025
| # Check request language | ||
| if current_language not in valid_languages: | ||
| raise serializers.ValidationError( | ||
| gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.") |
There was a problem hiding this comment.
Suggested change
| gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.") | |
| gettext(f"Cannot create OperationalUpdate with the current language {current_language}, language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.") |
@udaynwa Verify?
| gettext(f"Language must be either '{valid_languages[0]}' or '{valid_languages[1]}'.") | ||
| ) | ||
| # Check payload language | ||
| language = validated_data.get("starting_language") |
There was a problem hiding this comment.
Suggested change
| language = validated_data.get("starting_language") | |
| starting_language = validated_data.get("starting_language") |
Firstly, We need to check if the language and body stating langauge are same or not!
| valid_languages = [dref.starting_language, dref.translation_module_original_language] | ||
| # Check request language | ||
| if current_language not in valid_languages: | ||
| raise serializers.ValidationError( |
| permission_classes=[permissions.IsAuthenticated, DenyGuestUserPermission], | ||
| ) | ||
| def finalize(self, request, pk=None, version=None): | ||
| field_report = self.get_object() |
There was a problem hiding this comment.
Suggested change
| field_report = self.get_object() | |
| final_report = self.get_object() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.