New database model #239
New database model #239
Conversation
bryan-brancotte
left a comment
bryan-brancotte
left a comment
There was a problem hiding this comment.
This is work in progress PR from what I observed, but in the right direction
.env-sample
Outdated
| @@ -0,0 +1,2 @@ | |||
| login= | |||
There was a problem hiding this comment.
please add the new credentials in the already existing config file settings.ini and add constant in settings.py which will make the credentials available in the app
| ('collection', models.ManyToManyField(blank=True, to='ifbcat_api.Collection')), | ||
| ('operating_system', models.ManyToManyField(blank=True, to='ifbcat_api.OperatingSystem')), | ||
| ('scientific_topics', models.ManyToManyField(blank=True, to='ifbcat_api.Topic')), | ||
| ('tool_credit', models.ManyToManyField(blank=True, to='ifbcat_api.ToolCredit')), |
There was a problem hiding this comment.
credit would be enough ?
| ('operating_system', models.ManyToManyField(blank=True, to='ifbcat_api.OperatingSystem')), | ||
| ('scientific_topics', models.ManyToManyField(blank=True, to='ifbcat_api.Topic')), | ||
| ('tool_credit', models.ManyToManyField(blank=True, to='ifbcat_api.ToolCredit')), | ||
| ('tool_licence', models.ForeignKey(blank=True, help_text='Licence of the tool.', null=True, on_delete=django.db.models.deletion.SET_NULL, to='ifbcat_api.licence')), |
There was a problem hiding this comment.
licence would be enough, and more accurate
| ('scientific_topics', models.ManyToManyField(blank=True, to='ifbcat_api.Topic')), | ||
| ('tool_credit', models.ManyToManyField(blank=True, to='ifbcat_api.ToolCredit')), | ||
| ('tool_licence', models.ForeignKey(blank=True, help_text='Licence of the tool.', null=True, on_delete=django.db.models.deletion.SET_NULL, to='ifbcat_api.licence')), | ||
| ('tool_type', models.ManyToManyField(blank=True, to='ifbcat_api.ToolType')), |
There was a problem hiding this comment.
more cleanup on the model is needed
ifbcat_api/urls.py
Outdated
| path('tool/<int:pk>/', views.ToolViewSet.as_view({'get': 'retrieve'})), | ||
| path('tool/<biotoolsID>/', views.ToolViewSet.as_view({'get': 'retrieve'})), | ||
| path('database/<int:pk>/', views.DatabaseViewSet.as_view({'get': 'retrieve'})), | ||
| path('tool/<fairsharingID>/', views.DatabaseViewSet.as_view({'get': 'retrieve'})), |
| @@ -0,0 +1,205 @@ | |||
| import json | |||
There was a problem hiding this comment.
File is not in the right place, should not be in tool/ directory
There was a problem hiding this comment.
File is not in the right place, should not be in
tool/directory
Moved to /model/
closes #228