Skip to content

fixrule(aria_descendant_valid): When the contained role is code, report a recommendation#2544

Open
tombrunet wants to merge 1 commit intomain-4.xfrom
issue-2539
Open

fixrule(aria_descendant_valid): When the contained role is code, report a recommendation#2544
tombrunet wants to merge 1 commit intomain-4.xfrom
issue-2539

Conversation

@tombrunet
Copy link
Copy Markdown
Member

@tombrunet tombrunet commented May 5, 2026

Summary

  • New or modified checker rule(s)
  • New or modified help files
  • Other (Provide information)

This PR is related to the following issue(s):

Testing reference:

  • Existing automated tests

I have conducted the following for this PR:

  • I validated this fix in my local env and provided testing information above
  • I understand that the title of this PR will be used for the next release notes.
  • I added I agree to the DCO at https://developercertificate.org/ for this contribution. as a comment after creating the pull request.

Assets to aide review attached

  • Links to design artifacts
  • Links to video walkthrough of user experience
  • Other

Definition of Done

  • Peer review complete
  • Secondary review complete
  • Staging deployment verified

@tombrunet tombrunet changed the title Change code in a presentational container to recommendation fixrule(aria_descendant_valid): When the contained role is code, report a recommendation May 5, 2026
@tombrunet
Copy link
Copy Markdown
Member Author

I agree to the DCO at https://developercertificate.org/ for this contribution.

@tombrunet tombrunet marked this pull request as ready for review May 5, 2026 19:36
@tombrunet tombrunet requested a review from chrisgrimley May 5, 2026 19:37
Copy link
Copy Markdown
Contributor

@chrisgrimley chrisgrimley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested the code but the logic at least makes sense to me @tombrunet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Consider downgrading the case of "code" in "button" to recommendation

2 participants