Conversation
hindessm
reviewed
Jun 1, 2026
| Sensitive bool | ||
| Synonyms []*ConfigSynonym | ||
| Type ConfigType // v3 | ||
| Documentation string // v3 |
Collaborator
There was a problem hiding this comment.
Why is this a string rather than a *string? It represents a nullable string so surely we'd want to represent the nil case?
v3 (KIP-569) adds the IncludeDocumentation field to the request and ConfigType plus Documentation to each config entry on the response, from Kafka 2.6.0. v4 makes the API flexible (compact types and tagged fields), from Kafka 2.8.0. Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v3 (KIP-569) adds the IncludeDocumentation field to the request and ConfigType plus Documentation to each config entry on the response, from Kafka 2.6.0.
v4 makes the API flexible (compact types and tagged fields), from Kafka 2.8.0.
Note: this is protocol only for now, not yet exposing the extra fields in admin.go, that’ll come in a follow up PR