fix: replace isPrimitiveType with more sophisticated isPrimitiveSchema#519
Merged
fix: replace isPrimitiveType with more sophisticated isPrimitiveSchema#519
Conversation
Signed-off-by: Dan Hudlow <dhudlow@us.ibm.com>
dpopp07
approved these changes
Nov 22, 2022
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 22, 2022
## @ibm-cloud/openapi-ruleset [0.44.3](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/openapi-ruleset@0.44.2...@ibm-cloud/openapi-ruleset@0.44.3) (2022-11-22) ### Bug Fixes * replace isPrimitiveType with more sophisticated isPrimitiveSchema ([#519](#519)) ([a4c0293](a4c0293))
|
🎉 This PR is included in version 0.44.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.96.4 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Hudlow dhudlow@us.ibm.com
PR summary
This is mostly @padamstx's work — pulling it out of #506 because this bug is causing me issues in review and that PR still has some open baggage.
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements: