-
Notifications
You must be signed in to change notification settings - Fork 340
Add support to build MCP Gateway for s390x platform #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Address issue with setting CONTAINER_RUNTIME when podman is the only runtime installed.
Add s390x container build support
@crivetimihai Feel free to add me as a reviewer here. I need an excuse to fire up an s390x qemu today. |
Thanks for the contribution Chris (@p4yl04d3r). Please review the below code and let me know your thoughts. Hi @p4yl04d3r , Can we do this instead (in both Containerfile and .lite file)? RUN set -eux; RUN chmod 644 /etc/profile.d/use-openssl.sh I have made the following suggestions:
PR REVIEW SUMMARY:
|
Address code review comments
Address code review comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes have been made to the 2 files as suggested.
Hi @jonpspri, |
β¨ Feature / Enhancement PR
π Epic / Issue
Link to the epic or parent issue:
Closes #1138
π Summary (1-2 sentences)
What does this PR add or change?
This feature adds support to build MCP gateway container for s390x platform.
π§ͺ Checks
make lint
passesmake test
passesUpdate Makefile to address issue that prevents podman from being used as container runtime when docker is not installed.
Update Makefile to add "linux/s390x" to "container-build-multi"
Added s390x support to Container.lite and Container files to successfully build "linux/s390x" container.
π Notes (optional)
Design sketch, screenshots, or extra context.
If the change introduces or alters an architectural decision, add or update an ADR in
docs/docs/adr/
and link it here._