migrating klog to zap logger and adding requestID for tracing - #318
Open
balraj111 wants to merge 64 commits into
Open
migrating klog to zap logger and adding requestID for tracing#318balraj111 wants to merge 64 commits into
balraj111 wants to merge 64 commits into
Conversation
balraj111
changed the title
Collaborator
|
🔴 Coverage decreased from 84.86% to 81.97% |
Collaborator
|
🔴 Coverage decreased from 84.86% to 81.96% |
- Removed hardcoded 'service' and 'component' fields from logger initialization - Updated cmd/main.go to remove .With() call adding these fields - Updated pkg/logger/factory.go to remove service field from both JSON and Console loggers - All tests passing with cleaner log output containing only relevant contextual fields
Collaborator
|
🔴 Coverage decreased from 84.86% to 81.96% |
Collaborator
|
🔴 Coverage decreased from 84.86% to 81.96% |
Collaborator
|
🔴 Coverage decreased from 84.86% to 81.96% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review