Pass constructor parameters in Service initialization #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KostasTsiounis
requested review from
JinhangZhang,
jasonkatonica,
johnpeck-us-ibm and
taoliult
jasonkatonica
requested changes
Nov 17, 2025
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/ibm/crypto/plus/provider/OpenJCEPlusProvider.java
Outdated
Show resolved
Hide resolved
KostasTsiounis
force-pushed
the
constructor_params
branch
from
a84c799 to
b3a83ae
Compare
johnpeck-us-ibm
requested changes
Nov 18, 2025
KostasTsiounis
force-pushed
the
constructor_params
branch
from
7ace0fb to
ccd853b
Compare
johnpeck-us-ibm
approved these changes
Nov 18, 2025
Member
|
AIX showed a performance increase for algorithm instantiation using our benchmark MessageDigestInstanceBenchmark.java which is a relatively tight loop for testing various digest instantiations. Full JMH data collected: |
KostasTsiounis
force-pushed
the
constructor_params
branch
from
52d918d to
5b85ca4
Compare
Current code ignores parameters that need to be passed to the constructor of a service that needs to be initialized. This change is rectifying this and ensuring parameters are appropriately forwarded to the service's constructor. A test to verify this is added using KDF services, which is currently the only one that seems to take advantage of this. Signed-off-by: Kostas Tsiounis <[email protected]>
KostasTsiounis
force-pushed
the
constructor_params
branch
from
5b85ca4 to
dc84ac1
Compare
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code ignores parameters that need to be passed to the constructor of a service that needs to be initialized.
This change is rectifying this and ensuring parameters are appropriately forwarded to the service's constructor.
A test to verify this is added using KDF services, which is currently the only one that seems to take advantage of this.
Signed-off-by: Kostas Tsiounis [email protected]