fix(cli): Harden cli issues (#535, #536, #529, #534)#947
Merged
Gbangbolaoluwagbemiga merged 1 commit intoJun 27, 2026
Merged
Conversation
|
@aadviksinghdebug is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@aadviksinghdebug Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
a1ae0ea
into
HyperSafeD:main
11 of 25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR hardens the
sanctifier-clitooling across multiple security, CI, and documentation dimensions to ensure it's robust and ready for production scaling. It rolls up four issues into a single branch.Work items completed:
#535): A dedicated backwards compatibility step is now included in the GitHub Actionse2e-coverage.ymlpipeline.#536): The CLI now defaults to safe paths and actively prevents directory traversal (e.g.,..) escapes when normalizing project paths to prevent unintended filesystem reads.#529): AddedPACKAGING_AND_INSTALL.mdwith contribution notes, build instructions, and correctly linked it up in theDOCUMENTATION_INDEX.md.#534): Unit tests and fixtures to assert completions generate correct headers and registration commands across bash, zsh, fish, and powershell shells.sha256_hexcustom implementation ofverify_deployment.rsand properly resolved unclosed curly brackets insidecli_tests.rsto unblock CI.Acceptance Criteria
DOCUMENTATION_INDEX.md).Closes #535
Closes #536
Closes #529
Closes #534