Skip to content

fix(cli,core): harden config resolution, format validation, exit code…#939

Merged
Gbangbolaoluwagbemiga merged 1 commit into
HyperSafeD:mainfrom
devjayy43:fix/issues-510-517-518-519-cli-core-hardening
Jun 26, 2026
Merged

fix(cli,core): harden config resolution, format validation, exit code…#939
Gbangbolaoluwagbemiga merged 1 commit into
HyperSafeD:mainfrom
devjayy43:fix/issues-510-517-518-519-cli-core-hardening

Conversation

@devjayy43

Copy link
Copy Markdown
Contributor

…s, and diagnostics

Closes #510
Closes #517
Closes #518
Closes #519

Summary

Describe the change, the motivation behind it, and any important implementation details.

Fixes #

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Maintenance or refactor

Testing

List the commands you ran and the scope of validation.

cargo fmt --all --check
cargo clippy --workspace --all-targets --all-features -- -D warnings
cargo test -p sanctifier-core --all-features
cargo test -p sanctifier-cli
cd frontend && npm test

Checklist

  • I ran the relevant tests locally, or explained why they were not needed.
  • I updated documentation for any user-facing behavior changes.
  • I added or updated tests for the change when appropriate.
  • I added a changelog or release-notes entry when needed, or confirmed none is required.
  • I verified this branch is up to date with main and merge conflicts are resolved.

…s, and diagnostics

Closes HyperSafeD#510 HyperSafeD#517 HyperSafeD#518 HyperSafeD#519

- (HyperSafeD#517) Add integration tests for config file resolution precedence
  (nearest .sanctify.toml wins; walks up to parent; defaults when absent)
- (HyperSafeD#518) Validate --format value early; reject unknown values with a clear
  error message; add sarif format dispatch to `sanctifier analyze`
- (HyperSafeD#519) Extract named exit-code constants to exit_codes.rs; wire
  AnalysisProfile (strict/lenient/audit/ci) into the exit-code decision
  in exec(); use EXIT_CODES::ERROR in main()
- (HyperSafeD#510) Add FindingCode::format_diagnostic() and lookup_finding_code()
  to sanctifier-core for structured, actionable diagnostic output; add
  unit tests for both helpers
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

@devjayy43 is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@devjayy43 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Gbangbolaoluwagbemiga Gbangbolaoluwagbemiga merged commit 8852b4a into HyperSafeD:main Jun 26, 2026
11 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment