fix: schema stability, path normalization, CLI help tests, vulndb ref…#937
Merged
Gbangbolaoluwagbemiga merged 3 commits intoJun 26, 2026
Merged
Conversation
…actor (HyperSafeD#509 HyperSafeD#515 HyperSafeD#516 HyperSafeD#520) - HyperSafeD#509 (sanctifier-core/sanctifier-cli): Restructure `analyze --format json` output to conform to schemas/analysis-output.json (schema_version 1.1.0). Add `findings` object with code-tagged Finding* types; move duration_ms and profile out of metadata (additionalProperties:false); remove non-schema keys from summary. Un-ignore `test_json_output_validates_against_schema`. Add threat-model and schema stability notes to sanctifier-core lib.rs. - HyperSafeD#515 (sanctifier-cli): Refactor vulndb.rs into vulndb/mod.rs (database I/O + validation) + vulndb/matcher.rs (pure scan engine + VulnMatch type), making the module boundary between loading and matching explicit. - HyperSafeD#516 (sanctifier-cli): Add 14 new CLI help/UX tests covering --version, unknown-subcommand error, per-subcommand --help output, shell completions, and top-level help listing all core commands. - HyperSafeD#520 (sanctifier-cli): Extract normalize_cli_path() helper with doc comment describing cross-platform backslash conversion; add 3 unit tests.
|
@STX-Boot is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
…SafeD#515 HyperSafeD#516 HyperSafeD#520 into new arch - analyze.rs: accept main's RuleRegistry-based run_analysis; add normalize_cli_path call for cross-platform path normalization (HyperSafeD#520); keep normalize_cli_path helper and unit tests; drop AnalysisCache (superseded by new approach) - lib.rs: keep threat model + schema stability module doc (HyperSafeD#509); accept main's structural imports and module declarations - vulndb/mod.rs: keep split module layout (HyperSafeD#515); accept main's dead_code allow - cli_tests.rs: keep all 15 help/UX tests (HyperSafeD#516); accept main's telemetry test
|
@STX-Boot Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Gbangbolaoluwagbemiga
merged commit 603a07d
into
HyperSafeD:main
11 of 23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…actor (#509 #515 #516 #520)
Closes tooling/sanctifier-core: Security hardening + threat model notes (JSON output schema stability) #509 (sanctifier-core/sanctifier-cli): Restructure
analyze --format jsonoutput to conform to schemas/analysis-output.json (schema_version 1.1.0). Addfindingsobject with code-tagged Finding* types; move duration_ms and profile out of metadata (additionalProperties:false); remove non-schema keys from summary. Un-ignoretest_json_output_validates_against_schema. Add threat-model and schema stability notes to sanctifier-core lib.rs.Closes tooling/sanctifier-core: Refactor for clearer module boundaries (vulnerability DB matching engine) #515 (sanctifier-cli): Refactor vulndb.rs into vulndb/mod.rs (database I/O + validation) + vulndb/matcher.rs (pure scan engine + VulnMatch type), making the module boundary between loading and matching explicit.
Closes tooling/sanctifier-cli: Add unit tests + fixtures (command surface & help UX) #516 (sanctifier-cli): Add 14 new CLI help/UX tests covering --version, unknown-subcommand error, per-subcommand --help output, shell completions, and top-level help listing all core commands.
Closes tooling/sanctifier-cli: Document behavior + contribution notes (path normalization (Windows/macOS/Linux)) #520 (sanctifier-cli): Extract normalize_cli_path() helper with doc comment describing cross-platform backslash conversion; add 3 unit tests.
Summary
Describe the change, the motivation behind it, and any important implementation details.
Fixes #
Type of change
Testing
List the commands you ran and the scope of validation.
Checklist
mainand merge conflicts are resolved.