[ISSUE-750] feat(en-us): add player gear status strings #236
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds English localization strings for new player gear status display settings in the damage meter feature, addressing issue #750. The changes introduce configuration options to toggle the display of various player gear statistics including status, affinity, raw damage, and elemental damage.
- Adds 5 new damage meter settings for displaying player gear statistics (status, affinity, raw damage, elemental damage)
- Introduces a new "GEAR STATUS" configuration group
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| String="Show player status" | ||
| Description="If enabled, HunterPie will display each player's status." /> | ||
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_AFFINITY" | ||
| String="Show player affinity" | ||
| Description="If enabled, HunterPie will display each player's current affinity." /> | ||
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_RAW_DAMAGE" | ||
| String="Show player true raw damage" | ||
| Description="If enabled, HunterPie will display each player's current true raw damage." /> | ||
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_ELEMENTAL_DAMAGE" | ||
| String="Show player elemental damage" |
There was a problem hiding this comment.
The String attributes for these new settings include "player" in the text (e.g., "Show player status", "Show player affinity"), which is inconsistent with the existing similar settings in this section. For example, line 4388 uses "Show DPS" and line 4391 uses "Show total damage" without the word "player". Consider removing "player" from these String values to maintain consistency: "Show status", "Show affinity", "Show true raw damage", and "Show elemental damage".
| String="Show player status" | |
| Description="If enabled, HunterPie will display each player's status." /> | |
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_AFFINITY" | |
| String="Show player affinity" | |
| Description="If enabled, HunterPie will display each player's current affinity." /> | |
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_RAW_DAMAGE" | |
| String="Show player true raw damage" | |
| Description="If enabled, HunterPie will display each player's current true raw damage." /> | |
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_ELEMENTAL_DAMAGE" | |
| String="Show player elemental damage" | |
| String="Show status" | |
| Description="If enabled, HunterPie will display each player's status." /> | |
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_AFFINITY" | |
| String="Show affinity" | |
| Description="If enabled, HunterPie will display each player's current affinity." /> | |
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_RAW_DAMAGE" | |
| String="Show true raw damage" | |
| Description="If enabled, HunterPie will display each player's current true raw damage." /> | |
| <Setting Id="DAMAGE_METER_SHOULD_SHOW_ELEMENTAL_DAMAGE" | |
| String="Show elemental damage" |
No description provided.