Skip to content

fix(writers): keep the same PDF version #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(writers): keep the same PDF version #1747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/core/writers/PDFStreamWriter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import PDFHeader from 'src/core/document/PDFHeader';
import PDFTrailer from 'src/core/document/PDFTrailer';
import PDFInvalidObject from 'src/core/objects/PDFInvalidObject';
import PDFName from 'src/core/objects/PDFName';
Expand Down Expand Up @@ -44,7 +43,7 @@ class PDFStreamWriter extends PDFWriter {
protected async computeBufferSize() {
let objectNumber = this.context.largestObjectNumber + 1;

const header = PDFHeader.forVersion(1, 7);
const header = this.context.header;

let size = header.sizeInBytes() + 2;

Expand Down
2 changes: 1 addition & 1 deletion src/core/writers/PDFWriter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class PDFWriter {
}

protected async computeBufferSize(): Promise<SerializationInfo> {
const header = PDFHeader.forVersion(1, 7);
const header = this.context.header;

let size = header.sizeInBytes() + 2;

Expand Down
10 changes: 10 additions & 0 deletions tests/api/PDFDocument.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,16 @@ describe(`PDFDocument`, () => {

await expect(noErrorFunc()).resolves.not.toThrowError();
});

it(`keep the same PDF version`, async () => {
const pdfDoc = await PDFDocument.load(unencryptedPdfBytes);
const pdfBytes = await pdfDoc.save();
const newPdfDoc = await PDFDocument.load(Buffer.from(pdfBytes));

expect(pdfDoc.context.header.toString()).toEqual(
newPdfDoc.context.header.toString(),
);
});
});

describe(`copy() method`, () => {
Expand Down