Say what the state/ canary does not catch - #13
Merged
Conversation
It compares file length rather than content, and both driver suites run it against the one shared directory so either can be failed by the other's writes. Written beside it because the obvious tidy-up, watching only this file's own writes, would miss the bug it exists to catch. reconcile-subs.js no longer points at the retired local runner for the lock design. The reasoning it was citing stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only in the tests. The canary that asserts the repository's
state/is untouched by a run has two properties worth writing down, because the obvious improvement to either would make it catch less:Both are the price of measuring the real directory, which is the one thing a harness bug cannot route around.
Separately,
reconcile-subs.jscited the local fulfillment runner as prior art for the lock design. That script is being retired, so the pointer goes and the reasoning stays. Nothing should send a reader to a file that no longer exists.Suite unchanged: 402 tests, 400 pass, 0 fail, 2 skipped.