Skip to content

liboping: remove sudo requirement #121388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

liboping: remove sudo requirement #121388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Formula/liboping.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ class Liboping < Formula
url "https://noping.cc/files/liboping-1.10.0.tar.bz2"
sha256 "eb38aa93f93e8ab282d97e2582fbaea88b3f889a08cbc9dbf20059c3779d5cd8"
license "LGPL-2.1-or-later"
revision 1

livecheck do
url :homepage
Expand Down Expand Up @@ -33,6 +34,11 @@ class Liboping < Formula
url "https://raw.githubusercontent.com/Homebrew/formula-patches/03cf8088210822aa2c1ab544ed58ea04c897d9c4/libtool/configure-pre-0.4.2.418-big_sur.diff"
sha256 "83af02f2aa2b746bb7225872cab29a253264be49db0ecebb12f841562d9a2923"
end
# Make oping and noping not require sudo
Copy link
Member

@SMillerDev SMillerDev Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be submitted and merged upstream

patch do
url "https://github.com/wfaulk/liboping/commit/c2a61f7a4cdc1b8203bca12dfd6665e99bf74df5.patch?full_index=1"
sha256 "67f382ffdd8e6660bb4befb40f0ec1e03649defcb181dee2d9eebdb644120bbb"
end

def install
system "./configure", "--disable-debug",
Expand All @@ -41,10 +47,6 @@ def install
system "make", "install"
end

def caveats
"Run oping and noping sudo'ed in order to avoid the 'Operation not permitted'"
end

test do
system bin/"oping", "-h"
system bin/"noping", "-h"
Expand Down