install steps: add {{arch}} template token - #23836
Merged
Merged
Conversation
- the deprecated `postflight` block exposed the cask's `arch`, but
its `postflight_steps` replacement did not, so migrating casks
had to duplicate steps in `on_arm` and `on_intel` blocks
- expand `{{arch}}` to the value the cask's `arch` stanza selected,
and to an empty string when no value matches, as `postflight` did
- leave `{{arch}}` verbatim for contexts without an `arch`
- fix the step path corrector wrapping allowed template helpers in
a second `#{}`, which autocorrected to `"#{#{arch}}"`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?AI-assisted: Claude Opus 5 drafted the patch, the tests and the documentation, and ran
brew lgtmand the reproduction below on macOS 26 arm64. I reviewed its output and will answer review comments myself.Resolves https://github.com/orgs/Homebrew/discussions/7055.
The deprecated
postflightblock delegatedarchto the cask, butpostflight_stepshas no equivalent, so a cask whose artefact name embeds the architecture has to duplicate every step acrosson_armandon_intelafter migrating.{{arch}}now expands to the value the cask'sarchstanza selected, and to an empty string when nothing matches, aspostflightdid. A context without anarch, such as a formula, leaves the token verbatim.