More deprecations - #23783
Conversation
0910ca7 to
b863a6c
Compare
b863a6c to
405f493
Compare
405f493 to
b0d6bf5
Compare
e82d69c to
623ae27
Compare
|
Now that I've worked through all the related fixes, I opened a draft PR for the livecheck user agent fallback deprecation (#23834). I had been sitting on the deprecation changes while I worked through fixes, so apologies for the delay. I saw this PR after the fact but it may be better to have the deprecation as a separate PR anyway, as there are some fixes that still need to be merged before the deprecation can be merged or it will lead to failing checks (and I don't want to hold up your PR). That said, the approach I took differs in a notable way, where the deprecation is only triggered if the check succeeds with the fallback user agent. The idea is that triggering the deprecation for a check that fails regardless of user agent wouldn't be useful/applicable (i.e., it would mislead users). [I also seem to have taken a different approach to the tests, for better or worse.] Let me know what you think but please don't merge either user agent fallback deprecation until the fixes linked in my PR are all merged. |
- Use `pkg-config` or explicit include paths instead. - Stop injecting libxml2 paths into the macOS Superenv.
623ae27 to
916e01b
Compare
More deprecations for the next major/minor release.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Codex with GPT 5.6-sol at xhigh effort, with local review and testing.