formula_creator: add deny network for cabal and zig - #23739
Merged
Conversation
Contributor
There was a problem hiding this comment.
馃煛 Changes recommended
The inverted mode filter lacks regression coverage for all five excluded modes.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Extends generated Cabal formulae to separate dependency fetching from offline installation.
Changes:
- Enables network denial for Cabal formulae.
- Adds Cabal鈥檚 download-only fetch phase.
- Simplifies mode filtering and updates tests.
File summaries
| File | Description |
|---|---|
Library/Homebrew/formula_creator.rb |
Updates Cabal formula generation and network rules. |
Library/Homebrew/test/formula_creator_spec.rb |
Tests generated Cabal fetch behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
馃挕 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing work on extending
deny_network_access!.For Cabal, using
std_cabal_v2_argsas that includes resolver arguments (e.g. backjumps) which are needed during fetchdeny_network_access!聽homebrew-core#301832For Zig, can default to plain
--fetch(skip lazy deps) and switch to--fetch=allonly when lazy deps are needed:deny_network_access!and fetch聽homebrew-core#301864Also invert the list as shorter to list remaining modes. Still working on some issues with crystal (Homebrew/homebrew-core#301831)
and zig (Homebrew/homebrew-core#301796)before we can update formulae.Was also trying out Ruby
bundle cachebut working through some errors.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?