cask/upgrade: don't uninstall before upgrade #20814
Draft
+53
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is an initial pass at trying to skip the
uninstall
step when runningbrew upgrade
andbrew reinstall
.I have also added a simple dsl
uninstall_on_upgrade!
that would cause the uninstall to always run, for use in cases where it may be required.This is currently only accessible behind an ENV variable -
HOMEBREW_NO_UNINSTALL_ON_CASK_UPGRADE=1
.I have tested this with simple applications so far and it seems to work ok, but have not completed any testing with
pkg
orscript
installers yet.One blindside we may have here is that we do not test
brew upgrade
on CI, which means any future issues would only be surfaced by users, unless we had a way of running the upgrade on PRs.